https://bugzilla.redhat.com/show_bug.cgi?id=992951 --- Comment #3 from Paul Howarth <paul@xxxxxxxxxxxx> --- (In reply to Simone Caronni from comment #2) > I'm currently on holiday with very limited GPRS connectivity. I will address > all the issues you pointed in the previous comment when I come back on the > 19th of August. I will remove all EPEL support from it (originally it was > meant to update an EPEL perl package which has a dependency on this). Well, before you go hacking out the EPEL support, it may be possible to hack the test suite to work with an old version of Test::More. I've done this myself many times, and usually the thing you need to look for are: * If a test uses done_testing and you want to use it with Test::More < 0.88 (e.g. EPEL-5), you'll need to remove the done_testing and specify how many tests to expect (plan). * If a test uses subtests (needs Test::More 0.94, or Test::More 0.96 if there's no plan), you'll need to remove the subtests and run them as part of the main test (EPEL-6 had Test::More 0.94 I think). * Change note() to diag() to work with Test::More < 0.82 (e.g. EPEL-5). You'll also need to check out the other dependencies for the package to see if they can be satisfied in EPEL. If you're planning on having EPEL support it's best to try building the entire dependency stack you need in EPEL to make sure it's viable before you start submitting the package reviews, particularly if you're going to have to hack test suites in a few packages to get it to work. You might get near the top of the stack before realizing it's not going to be possible, which would save you some time in package reviews if you know it in advance. > Thanks very much for the review; if you need any review in return please let > me know. The only one I have outstanding is for perl-Archive-Any-Lite (Bug #991693) but hopefully someone will take it before you get back from holiday :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zwb0XqXLUA&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review