[Bug 875670] Review Request: ops4j-base - OPS4J Base

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=875670

Gerard Ryan <gerard@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Gerard Ryan <gerard@xxxxxxx> ---
(In reply to gil cattaneo from comment #3)
> (In reply to Gerard Ryan from comment #2)
> > 
> > Issues:
> > =======
> > - Bundled jar/class files should be removed before build
> >   Note: Jar files in source (see attachment)
> >   See:
> > http://fedoraproject.org/wiki/Packaging:Java#Pre-built_JAR_files_.
> > 2F_Other_bundled_software'
> 
>  they empty jars file used as resources for testing
>  ops4j-base-io/src/test/resources/dirscanner/bundle1.jar
>  ops4j-base-io/src/test/resources/dirscanner/bundle2.jar
>  ops4j-base-io/src/test/resources/dirscanner/subdir/bundle3.jar
>  ops4j-base-io/src/test/resources/dirscanner/subdir/subdir/bundle4.jar
>  contains the empty jars archive
>  ops4j-base-io/src/test/resources/dirscanner.zip
> 
> if i must remove these ones, i should disable test suite

Oh yeah, that was an issue generated by the tool. I intended to insert a
comment saying that those other ones were fine, since they're just empty files.

All looks good now. Thanks for packaging!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YDHH5iUyuh&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]