https://bugzilla.redhat.com/show_bug.cgi?id=875670 --- Comment #3 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Gerard Ryan from comment #2) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > - Bundled jar/class files should be removed before build > Note: Jar files in source (see attachment) > See: > http://fedoraproject.org/wiki/Packaging:Java#Pre-built_JAR_files_. > 2F_Other_bundled_software' they empty jars file used as resources for testing ops4j-base-io/src/test/resources/dirscanner/bundle1.jar ops4j-base-io/src/test/resources/dirscanner/bundle2.jar ops4j-base-io/src/test/resources/dirscanner/subdir/bundle3.jar ops4j-base-io/src/test/resources/dirscanner/subdir/subdir/bundle4.jar contains the empty jars archive ops4j-base-io/src/test/resources/dirscanner.zip if i must remove these ones, i should disable test suite > - [!]: License field in the package spec file matches the actual license. > Spec file says: "ASL 2.0 and BSD and MIT". I didn't see any BSD or > MIT files, but the following file is EPL: > org.ops4j.base-base-1.4.0/ops4j-base-io/src/main/java/org/ops4j/io/ > ZipExploder.java fixed > - [!]: If the package is under multiple licenses, the licensing breakdown > must > be documented in the spec. > > - [!]: If the source package does not include license text(s) as a separate > file > from upstream, the packager SHOULD query upstream to include it. > reported @ https://ops4j1.jira.com/browse/BASE-40 Spec URL: http://gil.fedorapeople.org/ops4j-base.spec SRPM URL: http://gil.fedorapeople.org/ops4j-base-1.4.0-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OxoxCjgeFl&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review