https://bugzilla.redhat.com/show_bug.cgi?id=993456 --- Comment #2 from Michael Schwendt <bugs.michael@xxxxxxx> --- Packages aren't sponsored, people are. ;-) > BuildArch: noarch Mixed feelings here. This is another header-only API with nothing in the guidelines about that. I'd build it arch-specific like Joshua does for his libscrypt submission, because the test-suite involves compiling test programs. That would be the only way to run the test-suite for all target archs. Note that you could still build a metslib-devel.noarch package when moving the BuildArch tag into the subpackage definition. Making sure that no arch-specific files get included in that noarch package would be your responsibility (as before). > License: GPLv3 or CPL The source files claim "or later": GPLv3+ Please double-check. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22or_later_version.22_licenses A copy of the CPL license text is not included: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text > ./metslib/abstract-search.hh Contains only a CPL preamble and doesn't mention GPL. Could you contact upstream for license clarification? > Provides: %{name} = %{version}-%{release} Mixed feelings here, too. I would drop this particular virtual package name. You give packagers the choice to depend on _three_ different names, e.g. in BuildRequires: metslib, metslib-devel, metslib-static That complicates queries done with repoquery or other tools. > find %{buildroot} -name '*.la' -exec rm -f {} ';' Superfluous, since no libtool archive files gets build or installed. > %check > make test It overrides Fedora's optflags with -O3. https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags > Move pkgconfig file to /usr/share/pkgconfig (since package is noarch) Usually I review pkgconfig files. It contains a wrong libdir definition. Even if it were not used, one can retrieve it with pkgconfig: $ pkg-config --variable=libdir metslib /usr/lib And the wrong libdir is used in the CFLAGS, too: $ pkg-config --cflags metslib -I/usr/include/metslib-0.5 -I/usr/lib/metslib-0.5/include -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZWxr2DvvFg&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review