[Bug 993636] Review Request: perl-Text-BarGraph - ASCII bargraph generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=993636



--- Comment #3 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> Release:	1.0

That's unusual enough to be a eye-brow raiser.


> %defattr(-,root,root,755)

%defattr is obsolete since RPM 4.4:
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions


> %attr(644,root,root) %{_mandir}/man3/Text::BarGraph.3pm.gz
> %attr(644,root,root) %{perl_vendorlib}/Text/BarGraph.pm 

%attr is overhead here. Fix up ordinary permission issues _early_ (in %prep or
%install) with the %{_fixperms} macro, during "install" usage or with chmod.
Restrict %attr usage to really special cases (setuid/gid, non-root
owner/group), so you can grep spec files and locate such places easily.

> Text::BarGraph.3pm.gz

Prefer  Text::BarGraph.3pm*  since the compression applied by rpmbuild
on-the-fly may be customised/changed/disabled.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rjOl0IgO4K&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]