[Bug 990691] Review Request: erlang-sidejob - An Erlang library that implements a parallel, capacity-limited request pool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=990691



--- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> REVIEW:
> 
> Legend: + = PASSED, - = FAILED, 0 = Not Applicable

> erlang-sidejob.armv7hl: E: zero-length
> /usr/share/doc/erlang-sidejob/README.md
> ^^^ This is an upstream issue really, but there's no point in packaging an
> empty file.

Fixed. Thanks for spotting this.

> erlang-sidejob.spec: W: invalid-url Source0:
> basho-sidejob-0.2.0-0-ga954ada.tar.gz
> Please use https://github.com/basho/sidejob/archive/0.2.0.tar.gz as the
> Source. It can be downloaded directly.

Ok, fixed this.

Here is a new package:

* http://peter.fedorapeople.org/erlang-sidejob.spec
* http://peter.fedorapeople.org/erlang-sidejob-0.2.0-2.fc20.src.rpm

> Please fix the remaining issues with Source and %doc before uploading to
> Fedora Git. This package is
> 
> APPROVED.

Thanks! But you forgot to raise fedora-review flag to +.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c4pvswbPQN&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]