https://bugzilla.redhat.com/show_bug.cgi?id=990627 Peter Lemenkov <lemenkov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #7) > (In reply to Peter Lemenkov from comment #5) > Thank you for the review! > > > REVIEW: > > work ~/rpmbuild/SPECS: rpmlint ~/Desktop/jblas-* > > jblas.src:52: W: configure-without-libdir-spec > > > > ^^^ I advise you to use %configure instead of ./configure > I think that %configure will add additional options, which are not supported > by this ./configure, which is a custom script here, not a real standard one. > I think it should stay the way it is. > > > - The package MUST own all directories that it creates. Unowned directory - > > /usr/lib64/jblas/ . Please either add this > Fixed. > > > APPROVED. > > Updated spec: http://in.waw.pl/~zbyszek/fedora/jblas.spec > Updated srpm: http://in.waw.pl/~zbyszek/fedora/jblas-1.2.3-2.fc19.src.rpm > koji f19: http://koji.fedoraproject.org/koji/taskinfo?taskID=5779036 > koji f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=5779029 Ok, good. Proceed with the following: * https://fedoraproject.org/wiki/Package_SCM_admin_requests -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3qOj3TS6Oq&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review