[Bug 990627] Review Request: jblas - Java bindings for BLAS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=990627



--- Comment #7 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
(In reply to Peter Lemenkov from comment #5)
Thank you for the review!

> REVIEW:
> work ~/rpmbuild/SPECS: rpmlint ~/Desktop/jblas-*
> jblas.src:52: W: configure-without-libdir-spec
> 
> ^^^ I advise you to use %configure instead of ./configure
I think that %configure will add additional options, which are not supported by
this ./configure, which is a custom script here, not a real standard one.
I think it should stay the way it is.

> - The package MUST own all directories that it creates. Unowned directory -
> /usr/lib64/jblas/ . Please either add this 
Fixed.

> APPROVED.

Updated spec: http://in.waw.pl/~zbyszek/fedora/jblas.spec
Updated srpm: http://in.waw.pl/~zbyszek/fedora/jblas-1.2.3-2.fc19.src.rpm
koji f19: http://koji.fedoraproject.org/koji/taskinfo?taskID=5779036
koji f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=5779029

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n95fEdczTd&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]