[Bug 991639] Review Request: python-facct - Fig's accountancy tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=991639



--- Comment #6 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> remove unwanted .mo file (don't know how to use %search_lang
> while packaging simultaneously for Python2 qnd Python3.)

You could have asked. ;-)

https://fedoraproject.org/wiki/Packaging:Guidelines#Why_do_we_need_to_use_.25find_lang.3F


One solution would be straight-forward. You've had this

  %find_lang %{srcname}

which in the %{buildroot} contents found the message object files and created a
%files list in file "%{srcname}.lang". You could simply extract lines from that
file, which contain %{python_sitelib} or %{python3_sitelib} in their path to
create two new lists for your two sub-packages, which to use in your %files
sections instead of the original list:

  grep '%{python_sitelib}' %{srcname}.lang > py2%{srcname}.lang
  grep '%{python3_sitelib}' %{srcname}.lang > py3%{srcname}.lang


> %{python3_sitelib}/%{srcname}/__pycache__/*
> %{python3_sitelib}/%{srcname}/*/__pycache__/*

Here you show that you do know that you can use wildcards, but in the update
package you listed each and every installed file in the %files list. Wow, that
came unexpected. :)

The %files list for the python2 package can get as simple as:

  %{python_sitelib}/%{srcname}*

to include everything correctly.

Similarly for the python3 based subpackage. You didn't tell why you don't
include the __pycache__ directory, btw.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ioxUzIFUmU&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]