[Bug 971115] Review Request: mingw-lzma-sdk457 - SDK for lzma compression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=971115

Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |erik-fedora@xxxxxxxxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #2 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> ---
Taking for review

* You shouldn't replace license texts. If rpmlint indicates that the license
contains an invalid FSF address you should file a bug upstream and leave the
current license as is (the rpmlint warning can be ignored in that situation)
* Is it really necessary to manually change the character encoding of various
files (some of which aren't even used in the mingw build like the .sln and
.csproj files) ?
* The %post and %postun triggers aren't needed for mingw packages
* This package lacks .dll.a files (which are import libraries). These files are
really necessary if you want binaries to be able to link against this library

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=upOx7km0dS&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]