https://bugzilla.redhat.com/show_bug.cgi?id=972860 --- Comment #4 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> --- (In reply to Christopher Meng from comment #3) > 1. Well, not all times I can replace the COPYING, especially I cannot get > permission of upstream. > > But such error is not blocker. > > Changed to GPLv2+. I thought rpmlint errors were blockers, in this case it's ok. License tag, OK! > 2. I will suggest RPM adding iconsdir macro into main package, so now I will > revert to datadir/icons. Add BR of jpackage is not good ;0 Yup I was also surprised when I found the macro came from this package. > 3. desktop-file-install is not a MUST, if package installs its desktop file > by scripts but not by packager, we can validate it. > > That's why I add %check section to make sure the desktop file matches the > standard. Maybe the rule should be amended with something like "unless the upstream project provides it". Thanks for the explanation. > Spec URL: http://cicku.me/abakus.spec > SRPM URL: http://cicku.me/abakus-0.92-2.fc20.src.rpm The package looks good to me, what's next ? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=stL6uk2W95&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review