https://bugzilla.redhat.com/show_bug.cgi?id=972860 --- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. Well, not all times I can replace the COPYING, especially I cannot get permission of upstream. But such error is not blocker. Changed to GPLv2+. 2. I will suggest RPM adding iconsdir macro into main package, so now I will revert to datadir/icons. Add BR of jpackage is not good ;0 3. desktop-file-install is not a MUST, if package installs its desktop file by scripts but not by packager, we can validate it. That's why I add %check section to make sure the desktop file matches the standard. Spec URL: http://cicku.me/abakus.spec SRPM URL: http://cicku.me/abakus-0.92-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=coO9PgPluh&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review