https://bugzilla.redhat.com/show_bug.cgi?id=987738 Ed Santiago <santiago@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |santiago@xxxxxxxxxx --- Comment #1 from Ed Santiago <santiago@xxxxxxxxxx> --- 1. Should /etc/bash_completion.d/dput be marked %config? It really isn't one, and no other bash_completion.d files are marked as such on my F19 box: for i in /etc/bash_completion.d/*;do printf "%02x %s\n" $(rpm -q --qf "%{fileflags}\n" -f $i) $i;done|grep -v ^00 2. Trivial consistency nit: 'install ... dput' has a trailing slash in the destination dir; no other install has a trailing slash. 3. The mkdirs ... are they necessary? Review guidelines state that "A package must own all directories that it creates". I think it's safe to remove everything except the two %{_datadir/%{name} ones, because the rest are owned by the filesystem package. (Even bash_completion.d, despite the messy rpm -qif /etc/bash_completion.d|grep ^Name). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fvnNClGxGr&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review