[Bug 957053] Review Request: groonga-normalizer-mysql - MySQL compatible normalizer plugin for groonga

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=957053

--- Comment #7 from HAYASHI Kentaro <kenhys@xxxxxxxxx> ---
Thanks Michael!

(In reply to Michael Schwendt from comment #6)
> > ExclusiveArch:	%{ix86} x86_64
> 
> Since ExlusiveArch and ExcludeArch are related:
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#Architecture_Build_Failures
> 

I guess that 'You shold check koji build listed in ExclusiveArch:', don't you?
If so, here is the result of koji build. It seems OK for me...

$ koji build --scratch rawhide
SRPMS/groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm
Uploading srpm: SRPMS/groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm
[====================================] 100% 00:00:02 380.65 KiB 142.80 KiB/sec
Created task: 5677043
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=5677043
Watching tasks (this may be safely interrupted)...
5677043 build (rawhide, groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm): open
(arm02-builder22.arm.fedoraproject.org)
  5677045 buildArch (groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm, i686): open
(buildvm-09.phx2.fedoraproject.org)
  5677044 buildArch (groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm, x86_64):
open (buildvm-22.phx2.fedoraproject.org)
  5677044 buildArch (groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm, x86_64):
open (buildvm-22.phx2.fedoraproject.org) -> closed
  0 free  2 open  1 done  0 failed
  5677045 buildArch (groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm, i686): open
(buildvm-09.phx2.fedoraproject.org) -> closed
  0 free  1 open  2 done  0 failed
5677043 build (rawhide, groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm): open
(arm02-builder22.arm.fedoraproject.org) -> closed
  0 free  0 open  3 done  0 failed

5677043 build (rawhide, groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm)
completed successfully


> 
> > %package devel
> > Requires:       %{name} = %{version}-%{release}
> 
> https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
> 
> 

I've fixed!

> > %dir %{_libdir}/groonga
> > %dir %{_libdir}/groonga/plugins
> 
> These dirs are owned by groonga-libs already, and this package requires
> groonga-libs. It doesn't need to include these dirs, too.
> 
> 
> > %dir %{_libdir}/groonga/plugins/normalizers
> 
> Will there be other normalizers? Then this dir could/should be moved into
> the groonga-libs package.

As you pointed out, groonga package should own above directories.
So I've just removed it.


Spec URL:
http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-mysql.spec
SRPM URL:
http://kenhys.fedorapeople.org/groonga-normalizer-mysql/groonga-normalizer-mysql-1.0.5-3.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=061elz5dzy&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]