https://bugzilla.redhat.com/show_bug.cgi?id=987153 --- Comment #2 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> --- Thanks for reviewing! Spec URL: http://toshio.fedorapeople.org/packages/python-modernize.spec SRPM URL: http://toshio.fedorapeople.org/packages/python-modernize-0.2-2.fc17.src.rpm 1. Good catch on the BR for python-setuptools. Added. 2. That's stylistic. I prefer the wildcard for everything in the directory. I know that some people would rather be notified if the files in that directory change but I'd rather have the package build succeed and look at the sources when necessary (when updating a stable release). [One note: you're supposed to add a trailing slash to directories that you own so that it's obvious to people that you meant to include a directory recursively. So: %{python_sitelib}/libmodernize/ and %{python_sitelib}/%{srcname}-%{version}-py%{python_version}.egg-info/ are correct) 3 & 4. Thanks! yeah, I'm only pushing this back as far as EPEL6 (if that) so those are good changes. Fixed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3tfl8LjF46&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review