https://bugzilla.redhat.com/show_bug.cgi?id=987153 --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. Do you think adding BR for python-setuptools is OK? 2. %files %{python_sitelib}/* should be %{python_sitelib}/libmodernize %{python_sitelib}/%{srcname}-%{version}-py%{python_version}.egg-info 3. Remove these # sitelib for noarch packages, sitearch for others (remove the unneeded one) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} 4. No need to rm -rf %{buildroot} -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=woM9gcyCB7&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review