[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=984360

--- Comment #3 from Simone Caronni <negativo17@xxxxxxxxx> ---
(In reply to Simone Caronni from comment #2)
> - ldconfig called in %post and %postun if required.
>   Note: /sbin/ldconfig not called in joyce
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
> joyce.x86_64: E: library-without-ldconfig-postin /usr/lib64/libdsk.so.3.2.4
> joyce.x86_64: E: library-without-ldconfig-postun /usr/lib64/libdsk.so.3.2.4
[...]

Please add:

%post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

> [!]: Rpath absent or only used for internal libs.
>      Note: See rpmlint output
> joyce.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dskid ['/usr/lib64']
> [...]

Please add the following to the spec file; regenerating the %configure script
with autotools solves the issues:

--- joyce.spec.old    2013-07-22 10:22:32.409074418 +0200
+++ joyce.spec    2013-07-22 10:22:39.841008109 +0200
@@ -6,9 +6,12 @@
 URL:            http://www.seasip.info/Unix/Joyce
 Source0:        http://www.seasip.info/Unix/Joyce/%{name}-%{version}b.tar.gz

+BuildRequires:  autoconf
+BuildRequires:  automake
 BuildRequires:  SDL-devel
 BuildRequires:  libxml2-devel
 BuildRequires:  libpng-devel
+BuildRequires:  libtool

 %description
 JOYCE is an Amstrad PCW and PCW16 emulator.
@@ -25,6 +28,7 @@
 %setup -qn %{name}-%{version}b

 %build
+autoreconf -v -f --install
 %configure --enable-shared --disable-static
 make %{?_smp_mflags}

> [!]: License field in the package spec file matches the actual license.
>      Note: Checking patched sources after %prep for licenses. Licenses found:
>      "GPL (v2 or later) (with incorrect FSF address)", "*No copyright* GPL
> (v2
>      or later) (with incorrect FSF address)", "GPL (v2 or later)", "LGPL (v2
>      or later) (with incorrect FSF address)", "Unknown or generated". 64
> files
>      have unknown license. Detailed output of licensecheck in
>      /home/slaanesh/Documents/fedora/984360-joyce/licensecheck.txt

These are the licenses found by licensecheck; please adjust (GPLv2+ and LGPLv2+
should be ok):

- *No copyright* GPL (v2 or later) (with incorrect FSF address)
- GPL (v2 or later)
- GPL (v2 or later) (with incorrect FSF address)
- LGPL (v2 or later) (with incorrect FSF address)
- Unknown or generated

> [!]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>      Note: Found : Packager: Simone Caronni <negativo17@xxxxxxxxx>

This is my local .rpmmacros, please ignore.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0woBI0aBoD&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]