https://bugzilla.redhat.com/show_bug.cgi?id=986175 --- Comment #3 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Simone Caronni from comment #2) > (In reply to Simone Caronni from comment #1) > > [!]: Packager, Vendor, PreReq, Copyright tags should not be in spec file > > Note: Found : Packager: Simone Caronni <negativo17@xxxxxxxxx> > > That's my local .rpmmacros. > > > [!]: If the source package does not include license text(s) as a separate > > file > > from upstream, the packager SHOULD query upstream to include it. > > [!]: Package does not include license text files separate from upstream. > > Fixed in spec file; has it been reported upstream? yes @ https://github.com/FasterXML/jackson-module-jaxb-annotations/issues/21 > > > [!]: If the package is a rename of another package, proper Obsoletes and > > Provides are present. > > jackson-module-jaxb-annotations.noarch: W: self-obsoletion > > jackson2-module-jaxb-annotations <= 2.2.2 obsoletes > > jackson2-module-jaxb-annotations = 2.2.2 > > Can you fix this? Spec file should read: > > Obsoletes: jackson2-module-jaxb-annotations < %{version} > Provides: jackson2-module-jaxb-annotations = %{version} > done > As per: > https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming. > 2FReplacing_Existing_Packages > > Please fix it before importing. > > What is line 15 of the spec file? A leftover? > > #BuildRequires: glassfish-jaxb-api > > If that's some note (like "new version should require this") please add an > explanation. javax.xml.bind:jaxb-api is also bundled in openjdk, but this package requires this artefact (glassfish-jaxb-api, https://fedorahosted.org/fpc/ticket/292), the comment is just a reminder > > Package approved! thanks! Spec URL: http://gil.fedorapeople.org/jackson-module-jaxb-annotations.spec SRPM URL: http://gil.fedorapeople.org/jackson-module-jaxb-annotations-2.2.2-2.fc19.src.rpm New Package SCM Request ======================= Package Name: jackson-module-jaxb-annotations Short Description: JAXB annotations support for Jackson (2.x) Owners: gil Branches: f19 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9PR8fZXMud&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review