[Bug 982161] Review Request: python-kapteyn - The Kapteyn Python Astronomy package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=982161

Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |dominik@xxxxxxxxxxxxxx
              Flags|                            |fedora-review?

--- Comment #6 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> ---
Thanks for the initial review, Michał. Some comments from me below:

Is the package not compatible with python3? If it is, please build the python3
version as well.

I noticed this in the build log:

/usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_deprecated_api.h:11:2:
warning: #warning "Using deprecated NumPy API, disable it by #defining
NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
 #warning "Using deprecated NumPy API, disable it by #defining
NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION"

This warning appears a number of times, please report this upstream.

It looks like the following MINPACK-derived code (mpfit.[ch]) is bundled:
http://cow.physics.wisc.edu/~craigm/idl/fitting.html

It appears to come originally from:
http://www.netlib.org/minpack/
and
http://people.sc.fsu.edu/~jburkardt/f_src/minpack/minpack.html

Please unbundle and package separately if possible or request a bundling
exception from FPC.

Another bundled code is ndimage from scipy (src/ndimg), which is available in
Fedora. Please remove src/ndimg in %prep as well and build against system
library.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1Ot6HK91el&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]