https://bugzilla.redhat.com/show_bug.cgi?id=984605 --- Comment #5 from Susi Lehtola <susi.lehtola@xxxxxx> --- (In reply to marcindulak from comment #4) > (In reply to Susi Lehtola from comment #3) > > The package MUST conform to the MPI guidelines. Also, you should add an > > mpich2 flavor. > OK - i found this > http://fedoraproject.org/wiki/Packaging:MPI#Packaging_of_MPI_software but > can you suggest me a recent, good style MPI software spec as a template? I > think i will drop el5 - it does not use this new packaging convention. Well, you can look at cp2k or gromacs, for instance. > > You don't need to conditionalize the BuildRoot etc statements for EL5. The > > statements work just fine on newer distros as well. > but fedora-review complains about some of them, so i got suggestion to > include them conditionally for el5 in bug #976886 comment #4 Then this is a bug in fedora-review. Fedora-review is just a simple and dumb tool, which may not be totally in touch with Fedora policies. Having the statements doesn't hurt anything; if you don't have them, new versions of rpm just use default values. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tksld6nFxx&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review