https://bugzilla.redhat.com/show_bug.cgi?id=926034 --- Comment #5 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Christopher Meng from comment #4) > No big problem here. > > Should be given + > > Only a suggestion: > > %global module_name catkin_pkg > > Well module_name is 11 chars, and catkin_pkg is 10 chars, why not keeping > its original name? It isn't to do with saving space. It's to do with clarity. Rich, I forgot to mention: the make file doesn't have a doc target. The docs folder doesn't have much as docs anyway. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1SBjKhi9W1&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review