https://bugzilla.redhat.com/show_bug.cgi?id=926034 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #4 from Christopher Meng <cickumqt@xxxxxxxxx> --- No big problem here. Should be given + Only a suggestion: %global module_name catkin_pkg Well module_name is 11 chars, and catkin_pkg is 10 chars, why not keeping its original name? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uSWTvfkLxN&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review