https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #6 from Volker Fröhlich <volker27@xxxxxx> --- ls was not written to be parsed. I think that many people would consider it bad practice, but I leave that up to you. I have no idea what that crashhandler binary does. It has no help, no man page and it doesn't say a lot anyway. I'd really consider prefixing the name or even removing it. It doesn't seem to be meant for standalone execution. I wonder if it should really be in bindir then. pgmodeler-devel.x86_64: E: incorrect-fsf-address /usr/include/pgmodeler/modeloverviewwidget.h pgmodeler.x86_64: W: unstripped-binary-or-object /usr/lib64/pgmodeler/plugins/libdummy.so pgmodeler.x86_64: W: unstripped-binary-or-object /usr/lib64/pgmodeler/plugins/libxml2object.so Where's that "_r1" in the version from? Are you sure you want that as part of the version and not release? The Qt patches are irrelevant for upstream or already included? I usually try to have a comment about the status in the spec file or the patch. I'm not sure if everything that is below /etc really belongs there. I also found an icon there, by the way. The bash completion script should be handled differently too: Completion scripts are loaded on demand from bash-completion 1.99 on -- http://mm3test.fedoraproject.org/hyperkitty/list/devel@xxxxxxxxxxxxxxxxxxxxxxxxx/thread/4PV7CQUQ2POT52EDMRUKZUKR4PEQYEG6/ mkdir -p %{buildroot}%{completion_path} mv %{buildroot}%{_sysconfdir}/bash_completion.d/pgmodeler-cli-completion.bash %{buildroot}%{completion_path}/pgmodeler-cli These commands are written under the assumption the completion is for the cli binary. If that's worth anything standalone, I'd suggest to have a subpackage. pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libutils.so.1.0.0 /lib64/libpq.so.5 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libutils.so.1.0.0 /lib64/libQtGui.so.4 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libutils.so.1.0.0 /lib64/libxml2.so.2 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libutils.so.1.0.0 /lib64/libXext.so.6 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libutils.so.1.0.0 /lib64/libX11.so.6 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libutils.so.1.0.0 /lib64/libm.so.6 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libpq.so.5 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libxml2.so.2 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libXext.so.6 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libX11.so.6 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libm.so.6 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdbconnect.so.1.0.0 /lib64/libQtGui.so.4 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdbconnect.so.1.0.0 /lib64/libxml2.so.2 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdbconnect.so.1.0.0 /lib64/libXext.so.6 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdbconnect.so.1.0.0 /lib64/libX11.so.6 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdbconnect.so.1.0.0 /lib64/libm.so.6 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libpq.so.5 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libxml2.so.2 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libXext.so.6 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libX11.so.6 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libpq.so.5 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libxml2.so.2 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libXext.so.6 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libX11.so.6 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libparsers.so.1.0.0 /lib64/libpq.so.5 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libparsers.so.1.0.0 /lib64/libQtGui.so.4 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libparsers.so.1.0.0 /lib64/libpthread.so.0 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libparsers.so.1.0.0 /lib64/libXext.so.6 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libparsers.so.1.0.0 /lib64/libX11.so.6 pgmodeler.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libparsers.so.1.0.0 /lib64/libm.so.6 There's some unnecessary linking going on. If these libraries are meant to be used by other applications than that GUI, that should probably be resolved. The locale script doesn't work because the locales are expected to have some kind of prefix to fr_FR. If you prefix them with something like pgmodeler_ and run %find_lang %{name} --with-qt, it works. You need to exclude the file list duplicates too. In my experience, you don't need to BR gettext. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qsdJoLjFqH&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review