https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #5 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> --- Hello Volker. >Is there no icon? I have not found file intended to be icon. But in .desktop file for that use pgmodeler_logo.png > Also try to get the desktop file upstream, if you haven't done so yet. https://github.com/pgmodeler/pgmodeler/issues/278 > I think you should rather use find than ls as a source to your loop. Sure. What it changes? Is there advantages for that particular case? > /usr/bin/crashhandler is a potentially problematic name. Sure. But at first glance via "repoquery --whatprovides /usr/bin/crashhandler" it is not used yet. > The locales aren't handled properly, see I have tried do that initially, but its does not found. Rpmbuild fails with error: $ /usr/lib/rpm/find-lang.sh /home/pasha/SOFT/rpmbuild/BUILDROOT/pgmodeler-0.5.1_r1-3.GITbe5b74a.fc19.x86_64 pgmodeler No translations found for pgmodeler in /home/pasha/SOFT/rpmbuild/BUILDROOT/pgmodeler-0.5.1_r1-3.GITbe5b74a.fc19.x86_64 Do you have ideas why? Other issues addressed, thank you for the comments. Spec: https://github.com/Hubbitus/Fedora-packaging/blob/f58ef89a618732e93c2b8adbd4c7f9629ea8109c/SPECS/pgmodeler.spec Spec changes: https://github.com/Hubbitus/Fedora-packaging/commit/f58ef89a618732e93c2b8adbd4c7f9629ea8109c Srpm: http://hubbitus.info/rpm/Fedora19/pgmodeler/pgmodeler-0.5.1_r1-3.GITbe5b74a.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RYLwFGOfJu&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review