https://bugzilla.redhat.com/show_bug.cgi?id=981707 Thomas Graf <tgraf@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tgraf@xxxxxxxxxx) | --- Comment #5 from Thomas Graf <tgraf@xxxxxxxxxx> --- (In reply to Christopher Meng from comment #4) > Review from the first URL of SRPM, not sure if this one. spec and SRPM updated in place. > Many issues: > > 1. 2 files with unknown license > > include/bmon/defs.h This is auto generated > include/bmon/list.h The header clearly states it comes from the kernel source. > 2. In %files section, %{_sysconfdir}/bmon.conf should be: > > %config(noreplace) %{_sysconfdir}/bmon.conf Fixed > 3. rpmlint: > explicit-lib-dependency libconfuse > explicit-lib-dependency libnl3 Removed Requires > 4. Manpage has incorrect syntax: > manual-page-warning /usr/share/man/man8/bmon.8.gz 203: warning: macro `NF' > not defined > manual-page-warning /usr/share/man/man8/bmon.8.gz 205: warning: macro `FI' > not defined Fixed in git tree, will be included in 3.2 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nHLwej13OP&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review