[Bug 981707] Review Request: bmon - bandwidth monitor and rate estimator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=981707

--- Comment #4 from Christopher Meng <cickumqt@xxxxxxxxx> ---
Review from the first URL of SRPM, not sure if this one.

Many issues:

1. 2 files with unknown license

include/bmon/defs.h
include/bmon/list.h

2. In %files section, %{_sysconfdir}/bmon.conf should be:

%config(noreplace) %{_sysconfdir}/bmon.conf

3. rpmlint: 
explicit-lib-dependency libconfuse
explicit-lib-dependency libnl3

4. Manpage has incorrect syntax:
manual-page-warning /usr/share/man/man8/bmon.8.gz 203: warning: macro `NF' not
defined
manual-page-warning /usr/share/man/man8/bmon.8.gz 205: warning: macro `FI' not
defined

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sxEdcyvVav&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]