[Bug 980071] Review Request: python-xpyb - X Python Binding, based on the X C Binding (XCB) library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=980071

--- Comment #3 from Tomas Dabašinskas <tdabasin@xxxxxxxxxx> ---
Christopher, appologies about the delay. Here's the diff of changes I've made:

--- python-xpyb.spec.old        2013-07-01 21:32:02.000000000 +1000
+++ python-xpyb.spec    2013-07-03 05:28:55.356712587 +1000
@@ -1,10 +1,7 @@
-%global src_name xpyb
-
 Name:          python-xpyb
-Version:       1.3
-Release:       2%{?dist}
-Summary:       X Python Binding,based on the X C Binding (XCB) library
-Group:         Development/Libraries
+Version:       1.3.1
+Release:       1%{?dist}
+Summary:       Python bindings to XCB
 License:       Public Domain
 URL:           http://xcb.freedesktop.org
 Source:                http://xcb.freedesktop.org/dist/xpyb-%{version}.tar.bz2
@@ -22,15 +19,11 @@
 - Python modules which are generated directly from the XCB-XML protocol
   descriptions.

-The Python binding requires libxcb.so to work. The additional extension
-libraries are not required.
-
-%package -n python-xpyb-devel
+%package devel
 Summary:       Devel files of xpyb
-Group:         Development/Libraries
-Requires:      python-xpyb == %{version}
+Requires:      %{name} = %{version}-%{release}

-%description -n python-xpyb-devel
+%description devel
 This package provides devel files of xpyb, a Python binding to the
 X Window System protocol via libxcb.

@@ -46,17 +39,15 @@
 %make_install

 %files
-%defattr(-,root,root,-)
 %{python_sitearch}/*
-%doc %{_docdir}/%{src_name}/*
+%doc %{_docdir}/xpyb/*

 %files devel
-%defattr(-,root,root)
-%{_libdir}/pkgconfig/%{src_name}.pc
+%{_libdir}/pkgconfig/xpyb.pc
 %{_includedir}/*.h

 %changelog
-* Mon Jul 01 2013 Tomas Dabasinskas <tomas@xxxxxxxxxx> - 1.3-2
+* Mon Jul 01 2013 Tomas Dabasinskas <tomas@xxxxxxxxxx> - 1.3.1-1
 - Minor edits for inclusion to fedora yum repo
 * Sat Apr 20 2013 Huaren Zhong <huaren.zhong@xxxxxxxxx> - 1.3
 - Rebuild for Fedora

If you don't mind I'd like to keep the original rpm author names. I am using
somebody else's work and I want to be fair, if you insist I remove the entries
I can do that.

Many thanks for your time on this review.

Spec URL:
http://people.fedoraproject.org/~tdabasin/python-xpyb/python-xpyb.spec
SRPM URL:
http://people.fedoraproject.org/~tdabasin/python-xpyb/python-xpyb-1.3.1-1.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vGiPzPvwc3&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]