https://bugzilla.redhat.com/show_bug.cgi?id=896087 Adrien Devresse <adev88@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Adrien Devresse <adev88@xxxxxxxxx> --- >As explain in the comments # We cannot use the archive tarball from github # as we don't have yet requirement for build (rake, sprockets or unusable version) Notice : build is, in fact, only compression. Fine for me, it was jsut a suggestion. your link come from the official website anyway. > I prefer to keep the upstream name (conflicts could also occurs in dir name, alias, ...). Accepted. > Hmm.. why ? It is correctly owned I usually use the syntax "%dir %{_datadir}/%{name}" explicitely but your solution does not leave trash directory. Fine for me. Anyway, it was just details. The package is globally really clean :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=meNQvk73ZU&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review