https://bugzilla.redhat.com/show_bug.cgi?id=896087 --- Comment #2 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- (In reply to Adrien Devresse from comment #1) > I take this review. > > Few comments : > > - From my knowledges, the directory ownership of %{_datadir}/%{name} need to > be specify explicitely Hmm.. why ? It is correctly owned > - Why not taking the source from the official github repo ? > https://github.com/sstephenson/prototype/releases > It include LICENSE file directly upstream and unit tests. As explain in the comments # We cannot use the archive tarball from github # as we don't have yet requirement for build (rake, sprockets or unusable version) Notice : build is, in fact, only compression. > - "prototype" is maybe just a bit generic for a name, Do you see any problem > to name it something like prototypejs (which map the official website name) > or prototype-javascript. > Nothing is against this in the naming guidelines ( > https://fedoraproject.org/wiki/Packaging:NamingGuidelines ), it's more a > comment from my side. I prefer to keep the upstream name (conflicts could also occurs in dir name, alias, ...). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5XUkTxt1ml&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review