[Bug 979652] Review Request: perl-Algorithm-TrunkClassifier - Implementation of the Decision Trunk Classifier algorithm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=979652

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?

--- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> ---

Review:

+ mock build is successful for f20

- rpmlint output on rpms gave
perl-Algorithm-TrunkClassifier.x86_64: E: script-without-shebang
/usr/lib64/perl5/vendor_perl/Algorithm/TrunkClassifier/Classification.pm
perl-Algorithm-TrunkClassifier.x86_64: E: wrong-script-end-of-line-encoding
/usr/lib64/perl5/vendor_perl/Algorithm/TrunkClassifier/Classification.pm
perl-Algorithm-TrunkClassifier.x86_64: E: script-without-shebang
/usr/lib64/perl5/vendor_perl/Algorithm/TrunkClassifier/Util.pm
perl-Algorithm-TrunkClassifier.x86_64: E: wrong-script-end-of-line-encoding
/usr/lib64/perl5/vendor_perl/Algorithm/TrunkClassifier/Util.pm
perl-Algorithm-TrunkClassifier.x86_64: E: script-without-shebang
/usr/lib64/perl5/vendor_perl/Algorithm/TrunkClassifier/DataWrapper.pm
perl-Algorithm-TrunkClassifier.x86_64: E: wrong-script-end-of-line-encoding
/usr/lib64/perl5/vendor_perl/Algorithm/TrunkClassifier/DataWrapper.pm
perl-Algorithm-TrunkClassifier.x86_64: E: script-without-shebang
/usr/lib64/perl5/vendor_perl/Algorithm/TrunkClassifier/DecisionTrunk.pm
perl-Algorithm-TrunkClassifier.x86_64: E: wrong-script-end-of-line-encoding
/usr/lib64/perl5/vendor_perl/Algorithm/TrunkClassifier/DecisionTrunk.pm
perl-Algorithm-TrunkClassifier-debuginfo.x86_64: E: description-line-too-long C
This package provides debug information for package
perl-Algorithm-TrunkClassifier.
perl-Algorithm-TrunkClassifier-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/Algorithm-TrunkClassifier-v1.0.1/Algorithm/TrunkClassifier/src/feature_selection.c
perl-Algorithm-TrunkClassifier-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/Algorithm-TrunkClassifier-v1.0.1/Algorithm/TrunkClassifier/src/feature_selection.h
3 packages and 0 specfiles checked; 9 errors, 2 warnings.
==> Fix these messages

+ Source verified with upstream as (sha256sum)
srpm tarball : e60ef3e6d189f007fe1f2d8424dda5e8ba072d4f0387b65ae0e9230abfba4c8a
upstream tarball :
e60ef3e6d189f007fe1f2d8424dda5e8ba072d4f0387b65ae0e9230abfba4c8a

+ License "Freely redistributable without restriction" is valid.

+ rest follows packaging guidelines

+ make test is successful with output
No tests defined.

+ package perl-Algorithm-TrunkClassifier-1.0.1-1.fc20
Provides: perl(Algorithm::TrunkClassifier) = 1.0.1
perl(Algorithm::TrunkClassifier::Classification) = 1.0.1
perl(Algorithm::TrunkClassifier::CommandProcessor) = 1.0.1
perl(Algorithm::TrunkClassifier::DataWrapper) = 1.0.1
perl(Algorithm::TrunkClassifier::DecisionTrunk) = 1.0.1
perl(Algorithm::TrunkClassifier::FeatureSelection) = 1.0.1
perl(Algorithm::TrunkClassifier::Util) = 1.0.1 perl-Algorithm-TrunkClassifier =
1.0.1-1.fc20 perl-Algorithm-TrunkClassifier(x86-64) = 1.0.1-1.fc20

Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) perl >= 1:5.010000
perl(Algorithm::TrunkClassifier::Classification)
perl(Algorithm::TrunkClassifier::CommandProcessor)
perl(Algorithm::TrunkClassifier::DataWrapper)
perl(Algorithm::TrunkClassifier::DecisionTrunk)
perl(Algorithm::TrunkClassifier::FeatureSelection)
perl(Algorithm::TrunkClassifier::Util) perl(Exporter) perl(POSIX)
perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH)

suggestions:
1) BR: perl not needed

2) rpmlint messages can be fixed by adding following in %prep
find . -type f  -exec chmod -x {} 2>/dev/null \;

3) Fix the description too long rpmlint message

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=I7WZgiW2TL&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]