[Bug 956931] Review Request: homerun - Application Launcher for KDE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=956931

--- Comment #23 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5569032

$ rpmlint -i -v *
homerun.src: I: checking
homerun.src: I: checking-url http://userbase.kde.org/Homerun (timeout 10
seconds)
homerun.src: I: checking-url
http://download.kde.org/stable/homerun/src/homerun-1.0.0.tar.bz2 (timeout 10
seconds)
homerun.i686: I: checking
homerun.i686: I: checking-url http://userbase.kde.org/Homerun (timeout 10
seconds)
homerun.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

homerun.i686: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/apps/homerun.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

homerun.i686: W: no-manual-page-for-binary homerunviewer
Each executable in standard binary directories should have a man page.

homerun.x86_64: I: checking
homerun.x86_64: I: checking-url http://userbase.kde.org/Homerun (timeout 10
seconds)
homerun.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

homerun.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/apps/homerun.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

homerun.x86_64: W: no-manual-page-for-binary homerunviewer
Each executable in standard binary directories should have a man page.

homerun-debuginfo.i686: I: checking
homerun-debuginfo.i686: I: checking-url http://userbase.kde.org/Homerun
(timeout 10 seconds)
homerun-debuginfo.x86_64: I: checking
homerun-debuginfo.x86_64: I: checking-url http://userbase.kde.org/Homerun
(timeout 10 seconds)
homerun-devel.i686: I: checking
homerun-devel.i686: W: no-dependency-on homerun/homerun-libs/libhomerun
homerun-devel.i686: E: description-line-too-long C The homerun-devel package
contains all the development files of the homerun launcher.
Your description lines must not exceed 80 characters. If a line is exceeding
this number, cut it to fit in two lines.

homerun-devel.i686: I: checking-url http://userbase.kde.org/Homerun (timeout 10
seconds)
homerun-devel.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

homerun-devel.x86_64: I: checking
homerun-devel.x86_64: W: no-dependency-on homerun/homerun-libs/libhomerun
homerun-devel.x86_64: E: description-line-too-long C The homerun-devel package
contains all the development files of the homerun launcher.
Your description lines must not exceed 80 characters. If a line is exceeding
this number, cut it to fit in two lines.

homerun-devel.x86_64: I: checking-url http://userbase.kde.org/Homerun (timeout
10 seconds)
homerun-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

homerun-libs.i686: I: checking
homerun-libs.i686: I: checking-url http://userbase.kde.org/Homerun (timeout 10
seconds)
homerun-libs.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

homerun-libs.x86_64: I: checking
homerun-libs.x86_64: I: checking-url http://userbase.kde.org/Homerun (timeout
10 seconds)
homerun-libs.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

homerun.spec: I: checking-url
http://download.kde.org/stable/homerun/src/homerun-1.0.0.tar.bz2 (timeout 10
seconds)
9 packages and 1 specfiles checked; 2 errors, 12 warnings.


No manpages, no docs in devel packages, no problem at all.
Some issues to be fixed:

The description line for the devel package is too long. Not in your text
editor, admittedly. But note, macros will be expanded and then the line becomes
longer. Split it in two lines, and rpmlint is happy again.

I don't know how critical is it to ship an svgz icon, but as long as it is
recognized correctly by the application, you should use the unzipped version.

Some runtime dependencies are still missing. The main package as well as the
-devel package need the -libs package. Add this line to both packages:

Requires: %{name}-libs%{?_isa} = %{version}-%{release}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bpdikp843z&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]