https://bugzilla.redhat.com/show_bug.cgi?id=980851 --- Comment #2 from Michael Schwendt <mschwendt@xxxxxxxxx> --- > 2. A good suggestion. %defattr is not needed by any active distribution release anymore, because all include RPM >= 4.4. When packaging for EPEL, think twice about how often you would copy from Fedora instead of creating a more losely connected branch. > 4. -q is short for "quiet output", without -q %setup would list the contents of tarballs when extracting them. Dropping -q can be helpful sometimes. For -n the default is %{name}-%{version}, and therefore it could be dropped, but if there is frequent need to package pre-/post-releases, it can be convenient to keep the -n %name-%version parameter since that makes it easy to adjust the top builddir as necessary for pre-/post-release directory names. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fEXbAuLF1x&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review