https://bugzilla.redhat.com/show_bug.cgi?id=980851 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. Why this? > "%define _binaries_in_noarch_packages_terminate_build 0" 2. No need for "BuildRoot" tag and "%defattr(-,root,root)" and "rm -rf %{buildroot}", Unless you are packaging for EPEL, but please, when creating the branch of el6, reedit the file, try not to preserve such lines in modern packaging system. 3. For the files warned by rpmlint, are those just configs which can be replaced when updating the package? If not add noreplace 4. %setup -q is ok, no need for -n with a name which is the default as -q. 5. I haven't tested the package, but are these perl requires cannot be detected by RPM when installing: Requires: perl(Text::Template) Requires: perl(Config::IniFiles) Requires: perl(File::Which) Requires: perl(File::Slurp) Requires: perl(Data::Dumper) If they can be automatically added when install xen-tools in a pure clean environment, please remove them IMO. 6. Hmm..a README under /etc, will you consider a move of it? 7. Consider the glob, I think you can shrink the size of spec. And use %{name} to replace xen-tools in %files if you like. I'm not a sponsor, but these reviews hope can be considered. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ynLa4o1lG5&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review