https://bugzilla.redhat.com/show_bug.cgi?id=979660 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + mock build is successful for f20 + rpmlint output on rpms gave perl-XML-Bare.src: W: spelling-error %description -l en_US struct -> strict, strut, struck perl-XML-Bare.x86_64: W: spelling-error %description -l en_US struct -> strict, strut, struck perl-XML-Bare.x86_64: W: spurious-executable-perm /usr/share/doc/perl-XML-Bare-0.52/META.json perl-XML-Bare.x86_64: W: spurious-executable-perm /usr/share/doc/perl-XML-Bare-0.52/Changes perl-XML-Bare.x86_64: W: spurious-executable-perm /usr/share/doc/perl-XML-Bare-0.52/README perl-XML-Bare.x86_64: E: script-without-shebang /usr/lib64/perl5/vendor_perl/XML/Bare.pm perl-XML-Bare-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/XML-Bare-0.52/parser.c perl-XML-Bare-debuginfo.x86_64: E: wrong-script-end-of-line-encoding /usr/src/debug/XML-Bare-0.52/parser.c perl-XML-Bare-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/XML-Bare-0.52/parser.h 3 packages and 0 specfiles checked; 2 errors, 7 warnings. ==> these should be fixed + Source verified with upstream as (sha256sum) srpm tarball : dc2e425282c4d55d152329ab14dd11c65b450dfcb06e97e81b18ad1c2b237dfb upstream tarball : dc2e425282c4d55d152329ab14dd11c65b450dfcb06e97e81b18ad1c2b237dfb - License "GPL+ or Artistic" is not exactly valid. + rest follows packaging guidelines + make test is successful with output All tests successful. Files=11, Tests=95, 2 wallclock secs ( 0.06 usr 0.01 sys + 1.14 cusr 0.21 csys = 1.42 CPU) + Package perl-XML-Bare-0.52-1.fc20 Provides: perl(XML::Bare) = 0.52 perl(XML::Bare::Object) perl-XML-Bare = 0.52-1.fc20 perl-XML-Bare(x86-64) = 0.52-1.fc20 Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libm.so.6()(64bit) perl(Carp) perl(Data::Dumper) perl(DynaLoader) perl(Exporter) perl(bytes) perl(strict) perl(utf8) perl(vars) rtld(GNU_HASH) suggestions: 1) Requires are not needed these should be automatically detected. Also, remove versions from BR: 2) License should be "GPLv2+ or Artistic" -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9b3JpLDPrf&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review