[Bug 979665] Review Request: perl-Data-MessagePack - MessagePack serialising/deserialising

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=979665

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f20

+ rpmlint output on rpms gave
perl-Data-MessagePack.src: W: spelling-error Summary(en_US) serialising ->
serializing, serialization
perl-Data-MessagePack.src: W: spelling-error Summary(en_US) deserialising ->
serializing
perl-Data-MessagePack.src: W: spelling-error %description -l en_US versa ->
avers, verse, verso
perl-Data-MessagePack.src: W: invalid-url URL:
http://search.cpan.org/dist/Data-MessagePack/ <urlopen error [Errno -2] Name or
service not known>
perl-Data-MessagePack.src: W: invalid-url Source0:
http://www.cpan.org/authors/id/G/GF/GFUJI/Data-MessagePack-0.47.tar.gz <urlopen
error [Errno -2] Name or service not known>
perl-Data-MessagePack.x86_64: W: spelling-error Summary(en_US) serialising ->
serializing, serialization
perl-Data-MessagePack.x86_64: W: spelling-error Summary(en_US) deserialising ->
serializing
perl-Data-MessagePack.x86_64: W: spelling-error %description -l en_US versa ->
avers, verse, verso
perl-Data-MessagePack.x86_64: W: invalid-url URL:
http://search.cpan.org/dist/Data-MessagePack/ <urlopen error [Errno -2] Name or
service not known>
perl-Data-MessagePack-debuginfo.x86_64: W: invalid-url URL:
http://search.cpan.org/dist/Data-MessagePack/ <urlopen error [Errno -2] Name or
service not known>
3 packages and 0 specfiles checked; 0 errors, 10 warnings.
==> looks clean

+ Source verified with upstream as (sha256sum)
srpm tarball     :
47225ee51263bd78324a0f2a3de800bf53344dc597cb64d58661e711bbab9ca8
upstream tarball :
47225ee51263bd78324a0f2a3de800bf53344dc597cb64d58661e711bbab9ca8

+ License "GPL+ or Artistic" is valid and included in source files.

+ rest follows packaging guidelines

+ make test is successful with output
All tests successful.

+ Package perl-Data-MessagePack-0.47-1.fc20
Provides: perl(Data::MessagePack) = 0.47 perl(Data::MessagePack::Boolean)
perl(Data::MessagePack::PP) perl-Data-MessagePack = 0.47-1.fc20
perl-Data-MessagePack(x86-64) = 0.47-1.fc20

Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) perl >= 0:5.008001
perl(B) perl(Carp) perl(Config) perl(strict) perl(warnings) rtld(GNU_HASH)

suggestions:
1) I don't think you need BuildRequires: perl, it will get pulled into build
environment.

2) you don't need versions in BR: or Requires:

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tpTPTi3KV5&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]