[Bug 980222] Review Request: perl-Class-Accessor-Classy - Accessors with minimal inheritance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=980222

--- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> ---
Do you plan to push this package into old EPEL repositories?  If not...

Line 37 is obsolete and should be removed:
 37 rm -rf %{buildroot}

So is line 39...:
 39 find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;

And also the whole %clean section and %defattr macro.


You're missing some build-time dependencies:
 - perl; called in spec, recommended
 - perl(attributes), lib/Class/Accessor/Classy.pm:676, recommended
 - perl(Carp), lib/Class/Accessor/Classy.pm:6, required
 - perl(strict), various places, recommended
 - perl(version), t/00-load.t:10, recommended
 - perl(warnings), various places, recommended


Note: Nowadays using simple 'perl' is preferred to the '%{__perl}' macro. 
However, that's up to you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rh0AgYYOYs&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]