https://bugzilla.redhat.com/show_bug.cgi?id=979648 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- > I want to know why we need to add perl(strict) and perl(warnings)? > I think they are in the perl package itself. They are in the perl package now, but that does not have to be true in the future. (See the Test::More case.) I agree that it's highly improbable in case of strict or warnings module, however treating all Perl modules the same way makes packaging more uniform. Spec file changes: --- perl-Tapper.spec.old 2013-06-29 06:15:26.000000000 +0200 +++ perl-Tapper.spec 2013-07-02 10:17:20.000000000 +0200 @@ -1,11 +1,17 @@ +%global pkgname Tapper + Name: perl-Tapper Version: 4.1.1 -Release: 1%{?dist} +Release: 2%{?dist} Summary: A flexible and open test infrastructure -License: 2-clause BSD +License: BSD Url: http://search.cpan.org/dist/Tapper/ -Source0: http://www.cpan.org/authors/id/T/TA/TAPPER/Tapper-%{version}.tar.gz -BuildRequires: perl(ExtUtils::MakeMaker) +Source0: http://www.cpan.org/authors/id/T/TA/TAPPER/%{pkgname}-%{version}.tar.gz +BuildRequires: perl +BuildRequires: perl(strict) +BuildRequires: perl(warnings) +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30 +BuildRequires: perl(Test::More) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) BuildArch: noarch @@ -16,27 +22,29 @@ infrastructure, extending it with automation and advanced querying. %prep -%setup -q -n Tapper-%{version} +%setup -qn %{pkgname}-%{version} %build %{__perl} Makefile.PL INSTALLDIRS=vendor make %{?_smp_mflags} -%check -make test - %install -make pure_install PERL_INSTALL_ROOT=%{buildroot} - +make pure_install DESTDIR=%{buildroot} find %{buildroot} -type f -name .packlist -exec rm -f {} \; -find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \; %{_fixperms} %{buildroot}/* +%check +make test + %files %doc Changes Changes-3.0.md Changes-4.0.md Changes-4.1.md LICENSE META.json README Starterpage.md %{perl_vendorlib}/* %{_mandir}/man3/* %changelog +* Tue Jul 02 2013 Christopher Meng <rpm@xxxxxxxx> - 4.1.1-2 +- Fix incorrect license. +- Cleanup. + * Fri Nov 30 2012 Christopher Meng <rpm@xxxxxxxx> - 4.1.1-1 - Initial Package. > FIX: Use `BSD' as license tag value. > See <https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses> > for normative license names. -License: 2-clause BSD +License: BSD Ok. > TODO: You can replace `%{__perl}' macros with plain `perl' command. Not addressed. > TODO: You can replace PERL_INSTALL_ROOT argument name with DESTDIR in > %install section. -make pure_install PERL_INSTALL_ROOT=%{buildroot} - +make pure_install DESTDIR=%{buildroot} Ok. > TODO: You do not need to remove empty directories in %install section. Modern > ExtUtils::MakeMaker does not produces ones. -find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \; Ok. > TODO: Build-require `perl' because you call at at various places in the spec file. +BuildRequires: perl Ok. > TODO: Build-require `perl(strict)' (Makefile.PL:2). +BuildRequires: perl(strict) Ok. > TODO: Build-requier `perl(warnings)' (Makefile.PL:3). +BuildRequires: perl(warnings) Ok. > TODO: Constrain `perl(ExtUtils::MakeMaker)' build-dependency with version > `>= 6.30' (Makefile.PL:7). +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30 Ok. > FIX: Build-require `perl(Test::More)' (t/release-eol.t:4). +BuildRequires: perl(Test::More) Ok. All tests pass. Ok. $ rpmlint perl-Tapper.spec ../SRPMS/perl-Tapper-4.1.1-2.fc20.src.rpm ../RPMS/noarch/perl-Tapper-4.1.1-2.fc20.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. Package builds in F20 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5564508). Ok Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gYC6cBhsLm&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review