[Bug 976886] Review Request: python-ase - Atomic Simulation Environment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=976886

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m

--- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
%{python_sitelib}/%{upstream_name}/gui/*.py*
%{python_sitelib}/%{upstream_name}/gui/languages

This way, your package doesn't own the folder

%{python_sitelib}/%{upstream_name}/gui/

To fix it, add

%dir %{python_sitelib}/%{upstream_name}/gui/



For the spec file I got the following warnings from rpmlint:

$ rpmlint -i -v *spec
python-ase.spec:98: W: macro-in-comment %{python_sitelib}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-ase.spec:98: W: macro-in-comment %{upstream_name}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-ase.spec:99: W: macro-in-comment %exclude
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-ase.spec:99: W: macro-in-comment %{python_sitelib}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-ase.spec:99: W: macro-in-comment %{upstream_name}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-ase.spec: I: checking-url
https://wiki.fysik.dtu.dk/ase-files/python-ase-3.7.1.3184.tar.gz (timeout 10
seconds)
0 packages and 1 specfiles checked; 0 errors, 5 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=N2FlCQlwQo&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]