https://bugzilla.redhat.com/show_bug.cgi?id=976886 --- Comment #1 from Björn Esser <bjoern.esser@xxxxxxxxx> --- Issues found, so far: * License-Tag is incorrect: MIT/X11 (BSD like) ------------------ python-ase-3.7.1.3184/ase/io/fortranfile.py ---> should be LGPLv2+ and MIT * Lots of sources and byte-compiled files end-up in %{_datadir}/%{name}/doc/: ---> there shouldn't be any byte-compiled stuff in docs they should be placed as %doc examples/, I think. * %defattr(-,root,root,-) is present: ---> not needed in all maintained F/EL branches please remove * BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) ---> prefered, but not mandatory, BuildRoot-path is: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) * macros in comments: python-ase.spec:98: W: macro-in-comment %{python_sitelib} python-ase.spec:98: W: macro-in-comment %{upstream_name} python-ase.spec:99: W: macro-in-comment %exclude python-ase.spec:99: W: macro-in-comment %{python_sitelib} python-ase.spec:99: W: macro-in-comment %{upstream_name} 0 packages and 1 specfiles checked; 0 errors, 5 warnings. ---> use doubled % to comment out these remove unneded non-explaining comments from spec * PatchX: %{name}-%{version}... ---> name of patch should be static. those patches may apply to later versions as well. You possibly want propose your patches for inclusion in upstream-source and provide a link to this in comments * you may wish to remove conditional around Version-tag by simply prefixing value of %{?upstream_svn} with a dot [.] * there are no manpages for %{_bindir}/* ---> since you are affiliated with upstream you may want to create and include them by upstream-source * Is there a way to have this build with python3, too? Please fix them and I'll take a more detailed review, then. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bff07cYZCy&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review