https://bugzilla.redhat.com/show_bug.cgi?id=894482 --- Comment #17 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Troy Dawson from comment #16) > - Reworked the doc section > -- added noarch > --- I put this in, but isn't this redundant because the package itself is a > noarch? Oh, sorry ... you are right. I did not realized that. My bad. * Is the %{gem_instdir}/conf worth of keeping? - Since its content is already copied into /etc, is the folder worth of keeping? Just asking ... > - Reworked %build section > -- Yes, it was originally that way because it is supposed to build on RHEL6. > -- It just looks to ugly to have the if statement, and since this will not > be going into EPEL6, I did a complete replacement with the %gem_install > macro. Well, you can always define the macro on top of the .spec file, if not available. That is IMO a bit better approach, since you don't pollute whole .spec file with ifdefs, there would be just one section on top. > -- Side note. I would love for that to make it into the RHEL6 > rubygems-devel package. It is so much cleaner. Yay, me too. I am trying to push PMs as much as I can, but still not sure if my effort will be successful in near future :/ > - Macroize /etc > -- This is due to the scl macro's. If we use the %{_sysconfdir} variable, > scl changes that from /etc/ to /opt/rh/<version>/root/etc/ while then breaks > everything. As guidelines strongly encourages usage of macros [1], I must strongly encourage you to use them as well. BTW, are you aware of %{_root_sysconfdir} SCL macro? You might try to redefine %{_sysconfdir} back to %{_root_sysconfdir} for SCL build or something less magical, i.e. define new constant which will differ for SCL and non-SCL builds. Actually, on second look, you are installing there just some .example file, not actual configuration, so not sure if it wouldn't be better to entirely forget about installing it into /etc and you would have this issue solved as well as the %{gem_instdir}/conf issue and you would get rid of "rubygem-openshift-origin-auth-kerberos-doc.noarch: W: non-conffile-in-etc /etc/openshift/plugins.d/openshift-origin-auth-kerberos.conf.example" rpmlint warning. * The runtime dependencies are not fulfilled - I observe following error: irb(main):002:0> require 'openshift-origin-auth-kerberos' Gem::LoadError: Could not find 'moped' (~> 1.4.2) - did find: [moped-1.5.0] - It seems that we have in fedora newer version of rubygem-moped then OO needs. * Description - Isn't the description too brief? It even does not mention OpenShift, although one could deduce it from the package name. Please consider to provide better description. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Macros -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=50ZBjuGveg&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review