https://bugzilla.redhat.com/show_bug.cgi?id=894482 --- Comment #16 from Troy Dawson <tdawson@xxxxxxxxxx> --- Spec URL: http://tdawson.fedorapeople.org/openshift-origin/rubygem-openshift-origin-auth-kerberos.spec SRPM URL: http://tdawson.fedorapeople.org/openshift-origin/rubygem-openshift-origin-auth-kerberos-1.5.1-2.fc20.src.rpm You were right, I had taken the upstreams stuff, and overlooked the doc header section as well as the files section. - Reworked files section -- moved Gemfile to -doc section -- prefixed %{gem_instdir} with %dir --- This brought out a bunch of duplicates, as well as extra directories --- Fixes the whole files section up - Reworked the doc section -- added Requires of the main package -- added noarch --- I put this in, but isn't this redundant because the package itself is a noarch? -- added group --- Just for you Vit ;) - Reworked %build section -- Yes, it was originally that way because it is supposed to build on RHEL6. -- It just looks to ugly to have the if statement, and since this will not be going into EPEL6, I did a complete replacement with the %gem_install macro. -- Side note. I would love for that to make it into the RHEL6 rubygems-devel package. It is so much cleaner. - No test -- Yep, upstream has been pretty hard to get standalone tests out of. - Macroize /etc -- This is due to the scl macro's. If we use the %{_sysconfdir} variable, scl changes that from /etc/ to /opt/rh/<version>/root/etc/ while then breaks everything. -- I do like your idea of something like a openshift-origin-devel package that has some variables like %{_openshiftconfdir} %{_openshiftplugindir} %{_openshiftlogdir} -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aGJ3OS09e1&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review