[Bug 974714] Review Request: thermal_daemon - A close loop thermal monitoring and control daemon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=974714

Antonio Trande <anto.trande@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anto.trande@xxxxxxxxx

--- Comment #3 from Antonio Trande <anto.trande@xxxxxxxxx> ---
Hi Srinivas.

> 1) Remove "BuildRequires:  gcc-c++", this not require this it essential part
> for minimum build system.
>  
> 2) Will your package build from EPEL5 ?
> if no, remove "%defattr(-,root,root)" in %files, this option only EPEL5.
> 
> 3) Adjust your %changelog in format like:
> from:
> "* Wed May 8 2013 Base version 1.0-1"
> To something like:
> "* Wed May 8 2013 Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> 1.0-1
> - Initial package"
> 
> In next adjusts increment your release this package, example 1.0-2.
> 

Also,

- URL/Source* refer to project's website and source files' location
respectively.
- Your package provides two .service files; please, refer to   
http://fedoraproject.org/wiki/Packaging:Systemd#Packaging guidelines

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7Fujhjbenf&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]