https://bugzilla.redhat.com/show_bug.cgi?id=974714 Marcelo Barbosa <firemanxbr@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |firemanxbr@xxxxxxxxxxxxxxxx | |g --- Comment #2 from Marcelo Barbosa <firemanxbr@xxxxxxxxxxxxxxxxx> --- I'm not officially Fedora packager yet, here my informal review: 1) Remove "BuildRequires: gcc-c++", this not require this it essential part for minimum build system. 2) Will your package build from EPEL5 ? if no, remove "%defattr(-,root,root)" in %files, this option only EPEL5. 3) Adjust your %changelog in format like: from: "* Wed May 8 2013 Base version 1.0-1" To something like: "* Wed May 8 2013 Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> 1.0-1 - Initial package" In next adjusts increment your release this package, example 1.0-2. Best regards. Marcelo Barbosa Fedora Project Ambassador firemanxbr@xxxxxxxxxxxxxxxxx -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9dxDar42WK&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review