https://bugzilla.redhat.com/show_bug.cgi?id=972568 --- Comment #4 from Christopher Meng <cickumqt@xxxxxxxxx> --- (In reply to Susi Lehtola from comment #3) > Source URL is incorrect > Source0: > http://prdownloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz > see > > http://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/ > SourceURL#Sourceforge.net Hi, thanks for your review help first. This project has been moved to github, I've fixed the problem. FYI, I've sent a mail to notify the upstream to provide the latest tarball on sf.net. Please go ahead(I won't ignore this.) > > BuildRequires: glibc-devel > can be removed, it's one of the packages that's automatically installed > anyway. Fixed. > The files don't belong in a package called uthash. Instead, they should go > to uthash-devel as per the packaging guidelines. > > You can, of course, make uthash-devel provide uthash, so that installing > uthash gives you uthash-devel. (There should be no main package.) I remembered that I've browsed some review requests like such case, reviewer approved. I think suck package is no problem. Welcome any ideas. > I abhor rampant use of wildcards in %files, because they can lead to > unwanted results, and often it's much clearer to just type out the few extra > letters to make things clear to anyone reading the spec. So I really suggest > changing > %{_includedir}/* > to > %{_includedir}/ut*.h OK, easy fix. Fails to build in mock > perl ./do_tests > test83 failed > test84 failed > 84 tests conducted, 2 failed. Hmm... I know this problem as it occured when I first built it. But then there are no problems, even fedora-review on my host is OK. I just scratch a build and it really failed, I'll try to fix that. I'll update this package later. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=udiMKegBgz&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review