https://bugzilla.redhat.com/show_bug.cgi?id=736861 --- Comment #18 from Mads Kiilerich <mads@xxxxxxxxxxxxx> --- (In reply to Björn Esser from comment #17) > ---> you should probably just split into two pkgs: Thank you for the opinion and advice. I am still convinced that curses should be a separate package. Installing hgview-curses can take 7.5 MB on disk including the dependencies. > - Package contains BR: python2-devel Right. The guidelines has changed since the package was created. > - update-desktop-database is invoked when required > Note: desktop file(s) in hgview > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache The package has no icons - only a pixmap. That section do thus not apply. You mean http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database ? No - the .desktop file has no MimeType. > - Packages should try to preserve timestamps of original installed files. > > ---> -install -m 644 -D %{SOURCE1} ... > +install -pDm 0644 %{SOURCE1} ... That is a file I created by converting the favicon from upstreams website. The "original" timestamp is completely irrelevant. The guidelines says "consider". But ok. > [!]: Rpmlint is run on all installed packages. > Note: Mock build failed ... > Installation errors > ------------------- > INFO: mock.py version 1.1.32 starting... ... > INFO: installing package(s): > /home/bjoern.esser/fedora/review/736861-hgview/results/hgview-1.7.1-3.fc20. > noarch.rpm > ERROR: Command failed: > # ['/usr/bin/yum', '--installroot', > '/var/lib/mock/fedora-rawhide-x86_64/root/', 'install', > '/home/bjoern.esser/fedora/review/736861-hgview/results/hgview-1.7.1-3.fc20. > noarch.rpm', '--setopt=tsflags=nocontexts'] > Error: Package: hgview-1.7.1-3.fc20.noarch (/hgview-1.7.1-3.fc20.noarch) > Requires: hgview-common = 1.7.1-3.fc20 > You could try using --skip-broken to work around the problem > You could try running: rpm -Va --nofiles --nodigest You said that before, and I pointed out that the command you show is attempting do do an invalid installation - that is not a mock build. Please explain what you are trying to do, what you are doing, and why you think that is the right thing to do. Spec URL: http://kiilerix.fedorapeople.org/hgview.spec SRPM URL: http://kiilerix.fedorapeople.org/hgview-1.7.1-4.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NEYcKjqovw&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review