https://bugzilla.redhat.com/show_bug.cgi?id=736861 --- Comment #16 from Mads Kiilerich <mads@xxxxxxxxxxxxx> --- (In reply to Björn Esser from comment #15) > ---> A package must NOT list a file more than once in the %files listings. > see: https://fedoraproject.org/wiki/Packaging/Guidelines#Duplicate_Files You are right. I have seen it used (for instance in grub2) and was sure it was allowed - and don't see why it shouldn't. Including files in multiple sub packages can make it possible to avoid -common packages and avoid providing something before it actually is available. However, I have moved more files to the -common package. > Installation errors ... > Error: Package: hgview-1.7.1-2.fc20.noarch (/hgview-1.7.1-2.fc20.noarch) > Requires: hgview-common = 1.7.1-2.fc20 Eeh? Yes, installing a package without its dependencies is an "installation error", not a packaging error. > ---> Why do you split-up the build in three noarched pkgs? > Having everything in a single noarch-pkg and an additional > qt-subpkg with desktop-file, icon and Requires: ${qt_stuff} hgview > would be fine, I suppose?! There are two independent UIs for hgview. qt users might not want to install the curses dependencies. > #hgview = %{python_sitelib}/hgext/hgview.py > > ---> should be: hgext.hgview = %{python_sitelib}/hgext/hgview.py No it should not. hgext is optional (and the left hand side doesn't matter when there is a right hand side). > Why do you comment-out by default? Because it is a best practice for Mercurial that extensions shouldn't be enabled by default. The ability to invoke hgview as 'hg hgview' instead of 'hgview' is also not essential. Spec URL: http://kiilerix.fedorapeople.org/hgview.spec SRPM URL: http://kiilerix.fedorapeople.org/hgview-1.7.1-3.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CJIdOtJLMs&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review