https://bugzilla.redhat.com/show_bug.cgi?id=736861 --- Comment #15 from Björn Esser <bjoern.esser@xxxxxxxxx> --- duplicate files packaged: `fdupes -r ${_reviewdir}/rpms-unpacked/` ./hgview-curses-1.7.1-2.fc20.noarch.rpm/etc/mercurial/hgrc.d/hgview.rc ./hgview-1.7.1-2.fc20.noarch.rpm/etc/mercurial/hgrc.d/hgview.rc ./hgview-curses-1.7.1-2.fc20.noarch.rpm/usr/share/man/man1/hgview.1.gz ./hgview-1.7.1-2.fc20.noarch.rpm/usr/share/man/man1/hgview.1.gz ./hgview-curses-1.7.1-2.fc20.noarch.rpm/usr/lib/python2.7/site-packages/hgext/hgview.py ./hgview-1.7.1-2.fc20.noarch.rpm/usr/lib/python2.7/site-packages/hgext/hgview.py ./hgview-curses-1.7.1-2.fc20.noarch.rpm/usr/lib/python2.7/site-packages/hgext/hgview.pyc ./hgview-1.7.1-2.fc20.noarch.rpm/usr/lib/python2.7/site-packages/hgext/hgview.pyc ./hgview-curses-1.7.1-2.fc20.noarch.rpm/usr/bin/hgview ./hgview-1.7.1-2.fc20.noarch.rpm/usr/bin/hgview 5 duplicate files (in 5 sets), occupying 8.2 kylobytes ---> A package must NOT list a file more than once in the %files listings. see: https://fedoraproject.org/wiki/Packaging/Guidelines#Duplicate_Files ##### Installation errors ------------------- INFO: mock.py version 1.1.32 starting... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Mock Version: 1.1.32 INFO: Mock Version: 1.1.32 Start: lock buildroot INFO: installing package(s): /home/bjoern.esser/fedora/review/736861-hgview/results/hgview-1.7.1-2.fc20.noarch.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-x86_64/root/', 'install', '/home/bjoern.esser/fedora/review/736861-hgview/results/hgview-1.7.1-2.fc20.noarch.rpm', '--setopt=tsflags=nocontexts'] Error: Package: hgview-1.7.1-2.fc20.noarch (/hgview-1.7.1-2.fc20.noarch) Requires: hgview-common = 1.7.1-2.fc20 ---> Why do you split-up the build in three noarched pkgs? Having everything in a single noarch-pkg and an additional qt-subpkg with desktop-file, icon and Requires: ${qt_stuff} hgview would be fine, I suppose?! ##### cat > $RPM_BUILD_ROOT%{_sysconfdir}/mercurial/hgrc.d/hgview.rc << EOT [extensions] # Enable hgview extension to be able to invoke hgview as 'hg hgview' or 'hg qv'. #hgview = %{python_sitelib}/hgext/hgview.py ---> should be: hgext.hgview = %{python_sitelib}/hgext/hgview.py Why do you comment-out by default? ##### Please fix those sure blockers and I'll run a more detailed review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7RyedKKQZI&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review