https://bugzilla.redhat.com/show_bug.cgi?id=969877 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Axilleas Pipinellis from comment #0) > SRPM URL: > https://github.com/axilleas/fedora/blob/master/packages/rubygem-timers/ > rubygem-timers-1.1.0-1.fc19.src.rpm?raw=true This is a bit weird URL. The one you provided for the .spec file is more wget friendly. This is just convenience remark ;) * Summary vs Description - Don't you have summary and description fields swapped? Summary is typically brief version of Description, while you have it the opposite way. Also the summary provided by upstream is "Pure Ruby one-shot and periodic timers" IMO, while you have this text in description. * Test suite - "pushd ." makes no sense IMO. - It would be better to do "push .%{gem_instdir}" instead. Currently, you are testing the unpacked version of gem, i.e. the gem as is unpacked in %prep section. That works for plain Ruby gem, but you could not use this approach for binary gem, since you would miss the compiled extension. Otherwise, the package looks good. However, prior I sponsor you and since this is trivial package, could you please take look on some other packages and do some informal review of them? You can finish their review later, once officially sponsored. Thanks. [1] http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DAgXfcNE91&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review