https://bugzilla.redhat.com/show_bug.cgi?id=961384 Stanislav Ochotnicky <sochotni@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sochotni@xxxxxxxxxx --- Comment #1 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> --- Not doing a full review, just a few comments: * missing description * Group tag is not really used/needed anymore * Why do you need Requires(post[un]): vim? There are no post[un] scriptlets * %defattr macro is not needed either -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9trfdM7HEw&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review