https://bugzilla.redhat.com/show_bug.cgi?id=967401 --- Comment #2 from Robin Lee <robinlee.sysu@xxxxxxxxx> --- (In reply to Douglas Schilling Landgraf from comment #1) > Hi Robin, > > I have few questions: > > 1) > BuildRequires: /usr/bin/dos2unix > BuildRequires: /usr/bin/mac2unix > > What about replace with: > > BuildRequires: dos2unix ? > > $ rpm -qf /usr/bin/dos2unix > dos2unix-6.0.1-1.fc18.x86_64 > $ rpm -qf /usr/bin/mac2unix > dos2unix-6.0.1-1.fc18.x86_64 What I actually use are the two commands, I don't have to care about what package that provides those commands. Yum would find out the package. > > 2) > %build > cc %{optflags} -o %{name} %{name}.c > > Why not "make %{?_smp_mflags}" ? > https://fedoraproject.org/wiki/PackagingGuidelines#Parallel_make Vmtouch is built from a single source file. And the upstream Makefile doesn't accept optflags setting. So I compile it directly with cc. > > Thanks > Douglas -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v60R0qKbF6&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review